small cleanups and optimizations #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a huge performance hit. Really, we just need to tell users not to modify the result. Also, get rid of an unnecessary pointer indirection (no api change).
This is checked when the protocol is *registered*. There's no reason to test it twice.
This will perform all the correct checks *except* that it won't bother actually stringifying the multiaddr. It should be significantly faster.
This showed up when profile go-ipfs.
|
Sounds good, but we should check all usages of |
|
I've now checked (as well as I can) and I can't find any cases where we mutate this. I'd also be quite surprised if there were. |
vyzo
approved these changes
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes one large change:
Bytes()no longer copies. IMO, copying was aterrible(ok, maybe not that bad) mistake and cost us significantly in terms of performance.This now just says "don't modify this or else...". IMO, that's a perfectly reasonable requirement (especially in go land).