Avoid problematic uses of 'is' #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'is' operator compares by object identity, which is not usually what you want unless comparing with singleton objects like None. Python 3.8 warns about suspicious uses of 'is' during byte-compilation. As an implementation detail, CPython interns small integers, so "1 + 1 is 2" is likely to be true, although this is not an API guarantee. However, "field is 'comment'" is unlikely to be true, because CPython allocates separate string objects for each instance of the same long string. Signed-off-by: Simon McVittie <[email protected]>
multani
added a commit
that referenced
this pull request
Feb 13, 2020
|
Once more: thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'is' operator compares by object identity, which is not usually
what you want unless comparing with singleton objects like None.
Python 3.8 warns about suspicious uses of 'is' during byte-compilation.
As an implementation detail, CPython interns small integers, so
"1 + 1 is 2" is likely to be true, although this is not an API guarantee.
However, "field is 'comment'" is unlikely to be true, because CPython
allocates separate string objects for each instance of the same long
string.