Run android-validate-gradle-wrapper on every matching push #6863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albin-mullvad
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
This prevents the following possible ways of commiting a malicious gradle-wrapper.jar to the repository: * Commiting to another path than the one previously specified * Pushing to `main` without going through a PR
faern
force-pushed
the
improve-android-gradle-wrapper-verifier
branch
from
5578a7b to
158017a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the following possible ways of commiting a malicious gradle-wrapper.jar to the repository:
mainwithout going through a PRPlease see these three comments for context: ossf/scorecard#4097 (comment)
I have not yet verified if scorecard will treat this new setup as a warning or not. But my impression was that the
scorecardcontributor in the comments sort of agreed that their verifier should be updated anyway.This change is