Update README.md #147
Open
Update README.md #147
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed wording of "If you find a block list that is included it is because we have gone through these validation steps:" to say "isn't included" rather than "is included", under the "Why is list "X" not included?" header. The way it reads currently contradicts the list that follows it, as the validation steps you take to INCLUDE a blocklist would ideally not result in a blocklist that "blocks things we do not believe should be blocked (like our own domains)." If I'm missing something, please disregard this update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed wording of "If you find a block list that is included it is because we have gone through these validation steps:" to say "isn't included" rather than "is included", under the "Why is list "X" not included?" header.
The way it reads currently contradicts the list that follows it, as the validation steps you take to INCLUDE a blocklist would ideally not result in a blocklist that "blocks things we do not believe should be blocked (like our own domains)."
However, the sentence in question should probably be further restructured for clarity, as it is likely not the case that any and all un-included blocklists they find have already been validated.
If I am missing something, please disregard this update.