Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saving issues #1142

Merged
merged 8 commits into from
Oct 12, 2022
Merged

Fix saving issues #1142

merged 8 commits into from
Oct 12, 2022

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Oct 12, 2022

Revert next.js, deal with broken polyfills as a result of that

Fixes #1057
Fixes #1082

  • This PR adds an integration test to prevent us from accidentally upgrading next.js to a bad version
  • This PR adds a few polyfills in a way that breaks once we update next.js again
  • This PR singles next out in renovatebot (temporary)

Special thanks to @WangLarry for pointing us in the direction of vercel/next.js#39262

@render
Copy link

render bot commented Oct 12, 2022

@oliviertassinari oliviertassinari requested a deployment to fix-next - toolpad-db PR #1142 October 12, 2022 14:46 — with Render Abandoned
@Janpot Janpot merged commit 3b1ddd6 into master Oct 12, 2022
@Janpot Janpot deleted the fix-next branch October 12, 2022 16:06
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work regression A bug, but worse labels Oct 12, 2022
Copy link
Member

@apedroferreira apedroferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work regression A bug, but worse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't save changes Fetch blocked
3 participants