[nextjs] fix hard crash of nextjs #270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoohahn
commented
Oct 11, 2024
yoohahn
commented
Oct 11, 2024
yoohahn
changed the title
yoohahn
force-pushed
the
fix/crashes
branch
2 times, most recently
from
df0b563
to
7d0c13b
Compare
brijeshb42
reviewed
Oct 16, 2024
brijeshb42
reviewed
Oct 16, 2024
| const error = new Error((e as Error).message); | ||
| error.stack = (e as Error).stack; | ||
| throw error; | ||
| } catch(e) { |
There was a problem hiding this comment.
Like stated in the pr comment that I am not sure how to show this. But regarding you will see it in the Error view in your browser.
Like my example repo
It is handled. So i am not really sure what this throw aims to do since it is not handle anywhere. So today it will just crash nextjs and you have to restart the process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr aims to fix this issue #268
In webpack I don't really see the need for throwing a new error. This throw will crash webpack. By just removing the throw we do get the Webpack Error in the browser.
Wrapping
this.handleCall(this.callParam, values);in a try catch also fixes the crash of using the theme object in wrong way. However I do not really get how this error should be displayed in the webpack error view. Need some help there