Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Fix row click propagation causing error in nested grid #9741

Merged
merged 2 commits into from
Jul 21, 2023
Merged

[DataGrid] Fix row click propagation causing error in nested grid #9741

merged 2 commits into from
Jul 21, 2023

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Jul 20, 2023 •
edited
Loading

@cherniavskii cherniavskii added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! labels Jul 20, 2023
@cherniavskii cherniavskii mentioned this pull request Jul 20, 2023
Closed
@mui-bot
Copy link

mui-bot commented Jul 20, 2023 •
edited
Loading

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-9741--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 314.3 598.1 390.2 413.74 105.02
Sort 100k rows ms 452.8 957.7 841.2 783.86 174.451
Select 100k rows ms 149.4 289.1 199.4 204.48 46.351
Deselect 100k rows ms 119.5 205.1 184.3 174.84 31.502

Generated by 🚫 dangerJS against 31b0fc2

@cherniavskii cherniavskii marked this pull request as ready for review July 20, 2023 19:46
@cherniavskii cherniavskii merged commit f908c2a into mui:master Jul 21, 2023
@cherniavskii cherniavskii deleted the fix-row-click-propagation-error branch July 21, 2023 19:22
MBilalShafi pushed a commit that referenced this pull request Aug 2, 2023
@cherniavskii @MBilalShafi
[DataGrid] Fix row click propagation causing error in nested grid (#9741
44f2492 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romgrk romgrk romgrk approved these changes

@m4theushw m4theushw Awaiting requested review from m4theushw

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Cannot read properties of undefined (reading 'type')
3 participants
@cherniavskii @mui-bot @romgrk