Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Fix quickfilter & aggregation error #9729

Merged
merged 6 commits into from
Jul 21, 2023

Conversation

romgrk
Copy link
Contributor

@romgrk romgrk commented Jul 19, 2023

Closes #9677

Prevent passing undefined which gets { ...row } into an empty object.

@romgrk romgrk added the component: data grid This is the name of the generic UI component, not the React module! label Jul 19, 2023
@mui-bot
Copy link

mui-bot commented Jul 19, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-9729--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 343.3 624.1 446.1 454.4 106.242
Sort 100k rows ms 547.4 1,076.5 547.4 891.1 199.764
Select 100k rows ms 149.9 241.3 210.1 205.62 30.886
Deselect 100k rows ms 154.9 278 223.3 224.84 47.503

Generated by 🚫 dangerJS against 68dc0cc

@romgrk romgrk enabled auto-merge (squash) July 21, 2023 19:38
@romgrk romgrk merged commit a22d608 into mui:master Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataGrid] Quick filter causes error in combination of row grouping and custom aggregation
3 participants