Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Add satisfies casting to slotProps #7859

Closed
wants to merge 6 commits into from

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Feb 8, 2023

Seems to finally be supported after recent babel package bumps. 🙌 👏

@LukasTy LukasTy added typescript component: pickers This is the name of the generic UI component, not the React module! labels Feb 8, 2023
@LukasTy LukasTy self-assigned this Feb 8, 2023
@mui-bot
Copy link

mui-bot commented Feb 8, 2023

Messages
📖 Netlify deploy preview: https://deploy-preview-7859--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 679.5 1,129.3 679.5 896.2 189.539
Sort 100k rows ms 740.5 1,356.8 1,356.8 1,080.54 227.804
Select 100k rows ms 210.6 329.1 301.3 289.18 40.671
Deselect 100k rows ms 140.9 353.6 254.9 246.26 73.885

Generated by 🚫 dangerJS against 88d72eb

@LukasTy
Copy link
Member Author

LukasTy commented Feb 9, 2023

False alarm. 🙈
Now both IDE and tsc are happy, but babel is still unable to parse satisfies.
There are others having the same issues: babel/babel#15157
I've tried most of the suggestions without success.
Hoping for a fix from babel (maybe @babel/preset-typescript)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants