Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DateTimePicker] Fix toolbar time order when theme.direction.rtl=true #6636

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

alexfauquette
Copy link
Member

Fix #5561

@alexfauquette alexfauquette added the l10n localization label Oct 26, 2022
@mui-bot
Copy link

mui-bot commented Oct 26, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-6636--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 571.3 1,276.7 732 876.02 242.751
Sort 100k rows ms 766.1 1,268.4 766.1 1,015.32 174.25
Select 100k rows ms 197 501.3 229.7 281.52 111.221
Deselect 100k rows ms 154.5 321.9 228.7 240.1 56.918

Generated by 🚫 dangerJS against 1e3b6dc

@alexfauquette alexfauquette merged commit e28780b into mui:next Oct 26, 2022
@alexfauquette alexfauquette deleted the fix-toolbar-rtl branch October 26, 2022 11:27
@Eliav2
Copy link

Eliav2 commented Dec 25, 2023

Fix toolbar time order when theme.rtl=true, could you elaborate? what theme.rtl? mui theme provider does not support rtl propery

@LukasTy LukasTy changed the title [DateTimePicker] Fix toolbar time order when theme.rtl=true [DateTimePicker] Fix toolbar time order when theme.direction.rtl=true Dec 27, 2023
@LukasTy
Copy link
Member

LukasTy commented Dec 27, 2023

Fix toolbar time order when theme.rtl=true, could you elaborate? what theme.rtl? mui theme provider does not support rtl propery

Thank you for bringing this up! 🙏
I've updated the PR title to be more precise.
We meant to say theme.direction.rtl instead of theme.rtl. 😉

@alexfauquette
Copy link
Member Author

@LukasTy Do we have a docs section about RTL?

I found this about extra unicode characters, but no section about how to setup RTL like for the data grid https://mui.com/x/react-data-grid/localization/#rtl-support

@LukasTy
Copy link
Member

LukasTy commented Dec 27, 2023

Do we have a docs section about RTL?

No, we don't. 🙈
That's a great idea! 💯
Created an issue: #11523. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pickers] Time in DateTimePickerToolbar is backwards in RTL theme
5 participants