[charts] Export data type in onAxisClick(_, data) callback #15038
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-15038--material-ui-x.netlify.app/ |
oliviertassinari
added
the
component: charts
oliviertassinari
changed the title
packages/x-charts/src/ChartsOnAxisClickHandler/ChartsOnAxisClickHandler.tsx
Outdated
Show resolved
Hide resolved
CodSpeed Performance ReportMerging #15038 will not alter performanceComparing Summary
|
|
@oliviertassinari locked and loaded ✅ pls 🙏 |
alexfauquette
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In a scenario where we'd like to have a controlled state that holds the axis data and make other components react to that state as we update it by clicking on the axes of the chart it would be very useful if we could re-use the
AxisDatatype. But it was not exported when I checked the source code.Main Feature
This PR's purpose is to
ChartsAxisDatatype making it possible to import it from the mui libraryFollow-ups After Review
AxisDatatoChartsAxisDataas per @oliviertassinari 's suggestionpnpm docs:api:buildwhich added the type to docs