-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Fix GridPanelAnchor
positioning
#15022
Conversation
GridPanelAnchor
widthGridPanelAnchor
width
Deploy preview: https://deploy-preview-15022--material-ui-x.netlify.app/ |
GridPanelAnchor
widthGridPanelAnchor
positioning
The change makes sense, but if we look at the root, it seems strange that we need this |
Hi @oliviertassinari , |
Ok, so the child |
On surface it looks like this approach was chosen because of the positioning issues of the preference panel |
@k-rajat19 Correct – topContainer didn't work, that's why I added panel anchor: |
Ok, thanks, so nothing else can be used here, nice regression fix 👍. Off-topic. One thing we could consider in the future is to change the anchor of the filter panel bested on the trigger. There is quite a long distance for the mouse to travel: https://mui.com/x/react-data-grid/filtering/ Screen.Recording.2024-10-21.at.16.10.17.movRelated to #6419. |
So there is no solution? |
The various grid management forms are all rendered inside a single panel. That logic is ugly and complex for no reason. Each toolbar button should manage its own popover panel, like a |
This PR should have fixed your issue, test with the latest version. |
Closes #15005
Before: https://codesandbox.io/p/sandbox/condescending-tereshkova-ytknq9
After: https://codesandbox.io/p/sandbox/mui-mui-x-x-data-grid-forked-sh3fw2?file=%2Fsrc%2Fdemo.tsx