Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Cleanup PageUp and PageDown event handlers on time components #14928

Merged
merged 2 commits into from
Oct 14, 2024
Merged

[pickers] Cleanup PageUp and PageDown event handlers on time components #14928

merged 2 commits into from
Oct 14, 2024

Conversation

arthurbalduini
Copy link
Member

@arthurbalduini arthurbalduini commented Oct 11, 2024 •
edited by oliviertassinari
Loading

@arthurbalduini arthurbalduini added performance component: pickers This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature labels Oct 11, 2024
@arthurbalduini arthurbalduini mentioned this pull request Oct 11, 2024
Merged
@mui-bot
Copy link

mui-bot commented Oct 11, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-14928--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 59ea1f1

@arthurbalduini arthurbalduini changed the title [pickers] Improve getFocusedListItemIndex function [pickers] Improve performance on PageUp and PageDown support on time components Oct 14, 2024
@LukasTy LukasTy changed the title [pickers] Improve performance on PageUp and PageDown support on time components [pickers] Cleanup PageUp and PageDown event handlers on time components Oct 14, 2024
LukasTy
LukasTy approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍
I've adjusted the PR title to avoid talking about performance, when the difference will not be perceivable to anyone. 🙈

@arthurbalduini arthurbalduini merged commit 5c44f5c into mui:master Oct 14, 2024
18 checks passed
@oliviertassinari
Copy link
Member

Nice, I would be curious to see the bundle size save this has, we would need to first setup #5550.

We had a thread with @Janpot about listRef.current! too in mui/material-ui#43939 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

@oliviertassinari oliviertassinari Awaiting requested review from oliviertassinari

Assignees
No one assigned
Labels
component: pickers This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arthurbalduini @mui-bot @oliviertassinari @LukasTy