Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Fix PickerValidDate usage in DateRangePickerToolbar #14925

Conversation

flaviendelangle
Copy link
Member

Fixes #14924
Same as #14896 but for DateRangePickerToolbar.

If someone could double check that he finds no import("moment") (or luxon or dayjs) in the bundle outside of the adapter file 😢

@flaviendelangle flaviendelangle changed the title [pickers] Fix PickerValidDate usage in DateRangePickerToolbar [pickers] Fix PickerValidDate usage in DateRangePickerToolbar Oct 11, 2024
@flaviendelangle flaviendelangle self-assigned this Oct 11, 2024
@flaviendelangle flaviendelangle added regression A bug, but worse component: pickers This is the name of the generic UI component, not the React module! labels Oct 11, 2024
@flaviendelangle flaviendelangle marked this pull request as ready for review October 11, 2024 14:49
@mui-bot
Copy link

mui-bot commented Oct 11, 2024

Deploy preview: https://deploy-preview-14925--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 47ced15

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👌
Tested locally, I didn't find any other instances of "| import("d"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! regression A bug, but worse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pickers] Cannot compile in TypeScript with skipLibCheck: false in MUI 7.20.0
3 participants