-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update flex parent demo to set min height for overlays #14900
Conversation
Deploy preview: https://deploy-preview-14900--material-ui-x.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
style={{ | ||
display: 'flex', | ||
flexDirection: 'column', | ||
minHeight: rows.length === 0 ? 200 : undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rationale: #14901 (comment)
@cherniavskii I didn't notice that you have created this PR 😅, I have just created #14901 to address that issue |
Would be great if the overlay had a minimum height instead. It's something you can do manually with some CSS. Ex:
Adding a minimum height on the flex container that you have to calculate based on the size of the overlay that you want seems a bit weird and it's a number that looks arbitrary. If I want a 104px overlay, I need to set a minHeight of 231px. 231px does't look great in the code and needs a comment above it to explain why it's such a specific number. It's also a number you have to change if you add a toolbar to the datagrid for example. |
Closing in favor of #15202 |
Fixes #14881 (comment)