[code-infra] Replace or remove all instances of e identifier
#14724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-14724--material-ui-x.netlify.app/ |
Janpot
reviewed
Sep 25, 2024
docs/data/data-grid/server-side-data/ServerSideErrorHandling.tsx
Outdated
Show resolved
Hide resolved
JCQuintas
reviewed
Sep 25, 2024
JCQuintas
reviewed
Sep 25, 2024
JCQuintas
reviewed
Sep 25, 2024
test/utils/pickers/describeGregorianAdapter/describeGregorianAdapter.ts
Outdated
Show resolved
Hide resolved
samuelsycamore
commented
Sep 25, 2024
JCQuintas
reviewed
Sep 26, 2024
JCQuintas
approved these changes
Sep 26, 2024
Janpot
reviewed
Sep 26, 2024
Co-authored-by: Jan Potoms <[email protected]> Signed-off-by: Sycamore <[email protected]>
LukasTy
approved these changes
Sep 30, 2024
flaviendelangle
approved these changes
Sep 30, 2024
samuelsycamore
commented
Sep 30, 2024
Signed-off-by: Sycamore <[email protected]>
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
This was referenced Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14693.
Preparing for mui/material-ui#43866
There are a few identifiers here that could be better named because I was running into the
no-shadowrule and wasn't entirely sure how best to proceed, and a few that I had to add ignore comments for because they're part of an "a-b-c" variable naming convention.