[DataGrid] Fix document reference when the grid is rendered in a popup window #14649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminmeh
added
bug 🐛
|
Deploy preview: https://deploy-preview-14649--material-ui-x.netlify.app/ |
arthurbalduini
pushed a commit
to arthurbalduini/mui-x
that referenced
this pull request
Sep 30, 2024
This was referenced Oct 25, 2024
This was referenced Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14591
Initially, the root element reference is
null.In
useEffectthat runs on init thedocumentreference will point to the main window's document, since this util is being used to get it.Issue will not be visible unless the grid is actually rendered in another window (popup). In that case, some event listeners will end up being attached to the wrong document.
Callbacks and other event handlers that are triggered after user actions are fine, since the reference is there by that time.
I have updated all places where
ownerDocumentis being used on first render.