-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Add columnGroupHeaderHeight
prop for sizing column group headers
#14637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenanYusuf
added
the
component: data grid
This is the name of the generic UI component, not the React module!
label
Sep 16, 2024
cherniavskii
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 👍🏻
cherniavskii
added
customization: css
Design CSS customizability
feature: Column groups
Related to the data grid Column groups feature
labels
Sep 17, 2024
arthurbalduini
pushed a commit
to arthurbalduini/mui-x
that referenced
this pull request
Sep 30, 2024
This was referenced Oct 25, 2024
This was referenced Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: data grid
This is the name of the generic UI component, not the React module!
customization: css
Design CSS customizability
feature: Column groups
Related to the data grid Column groups feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add columnGroupHeaderHeight prop for sizing column group headers https://deploy-preview-14637--material-ui-x.netlify.app/x/react-data-grid/column-groups/#group-header-height
Also added demo for the
columnHeaderHeight
prop as this seemed to be missing https://deploy-preview-14637--material-ui-x.netlify.app/x/react-data-grid/column-header/#header-heightFixes #10615