[DataGrid] Support minHeight and maxHeight on flex parent container
#14614
Conversation
cherniavskii
added
component: data grid
|
Deploy preview: https://deploy-preview-14614--material-ui-x.netlify.app/ Updated pages: |
| function ContainerMeasurements({ containerRef }) { | ||
| const [containerHeight, setContainerHeight] = React.useState(0); | ||
|
|
||
| useResizeObserver(containerRef, (entries) => { |
There was a problem hiding this comment.
I added this component to visualize the DataGrid height (no need to check it in the dev tools):
It works fine locally, but the resize observer callback is not called in the deploy preview for some reason 🫠
I'll look into it later, but the PR in its current form is ready for review.
There was a problem hiding this comment.
Fixed by 14cbefa (#14614)
Fixed by 6a9c2fa (#14614)
There was a problem hiding this comment.
Small issue with the scrollbar on chrome/linux (which usually behaves like chrome/windows):
Screencast.from.2024-09-18.17-48-40.webm
There was a problem hiding this comment.
Hmm, I can't reproduce it in Chromium on Ubuntu:
Screen.Recording.2024-09-19.at.01.36.24.mov
There was a problem hiding this comment.
It only happens when the zoom is not 100%.
There was a problem hiding this comment.
Ah, with non-100% zoom, I can reproduce this on MacOS as well 👍🏻
Will look into it!
There was a problem hiding this comment.
Fixed, and the fix also solves another issue that I didn't notice before: #14614 (comment)
There was a problem hiding this comment.
I don't think so, I can reproduce the issue with both 7.19.0 and 7.18.0 (before this PR was merged)
packages/x-data-grid/src/components/virtualization/GridBottomContainer.tsx
Outdated
Show resolved
Hide resolved
This reverts commit 14cbefa.
…er (mui#14614) Co-authored-by: Rom Grk <[email protected]>
Closes #3524
Closes #7588
Closes #9178
Closes #9274
Preview:
TODO
autoHeightprop?