-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Remove cell min-width / max-width styles #14448
[DataGrid] Remove cell min-width / max-width styles #14448
Conversation
Deploy preview: https://deploy-preview-14448--material-ui-x.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't reproduce the linked issue either 👍🏻
I think it's not relevant anymore after reducing DOM nodes rendered for each cell in #12013
Cool, I'm curious to see if we need to add this back: See https://youtu.be/tRsxLLghL1k?si=sRhbVRHVLRR83pMX&t=574. "if you are not adding back at least 10% of what you are removing, you know you are not removing enough". |
This is the result of a merge conflict. I refactored this in mui#14448 but this PR wasn't merged yet.
I can't reproduce this issue https://github.com/mui/mui-x/pull/10059/files#r1417671356 using:
so I'm continuing #13293 (comment). I suspect that we can save bundle size here.
Edit: how fun, the CI is failing with the data picker, unrelated, it seems because we are the 1st of the month, but not 100% sure.
Preview: https://deploy-preview-14448--material-ui-x.netlify.app/x/react-data-grid/