Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] Replace ESM extensions by .mjs #14387

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette added the component: charts This is the name of the generic UI component, not the React module! label Aug 29, 2024
@Janpot
Copy link
Member

Janpot commented Aug 29, 2024

I believe the exports field needs to be updated as well

"import": "./es/*.js",

Just to note, the .mjs extension is not critical or anything. It's just to extra minimize the chance for confusion of the tooling

@mui-bot
Copy link

mui-bot commented Aug 29, 2024

Deploy preview: https://deploy-preview-14387--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 0f92e2e

Copy link

codspeed-hq bot commented Aug 29, 2024

CodSpeed Performance Report

Merging #14387 will not alter performance

Comparing alexfauquette:ESM-vendore (0f92e2e) with master (cf441ec)

Summary

✅ 3 untouched benchmarks

@alexfauquette
Copy link
Member Author

Just to note, the .mjs extension is not critical or anything. It's just to extra minimize the chance for confusion of tools

It's such a quick win, that I prefer to do it now instead of adding it to the todo :)

@alexfauquette alexfauquette merged commit 3d767ba into mui:master Aug 29, 2024
19 checks passed
@alexfauquette alexfauquette deleted the ESM-vendore branch August 29, 2024 16:18
@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants