Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Add onTouchStart handler for TimeClock #14305

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

arthurbalduini
Copy link
Member

Closes #9312

@arthurbalduini arthurbalduini added component: pickers This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature labels Aug 23, 2024
@mui-bot
Copy link

mui-bot commented Aug 23, 2024

Deploy preview: https://deploy-preview-14305--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against c31d798

@@ -252,7 +252,7 @@ describe('<TimeClock />', () => {
},
],
},
'20:--': {
'19:--': {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This coordinates are actually pointing to 19

@LukasTy LukasTy added the component: TimePicker The React component. label Aug 29, 2024
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this! 🙏
The TimeClock feels much better like this. 💯

@arthurbalduini arthurbalduini merged commit 1be2f4c into mui:master Aug 29, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! component: TimePicker The React component. enhancement This is not a bug, nor a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pickers] Touch on analog clock doesn't feel responsive enough
3 participants