Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers][fields] Improve clear action label #14243

Merged
merged 1 commit into from
Sep 11, 2024
Merged

[pickers][fields] Improve clear action label #14243

merged 1 commit into from
Sep 11, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 16, 2024 •
edited
Loading

@oliviertassinari oliviertassinari added the component: pickers This is the name of the generic UI component, not the React module! label Aug 16, 2024
@oliviertassinari oliviertassinari mentioned this pull request Aug 16, 2024
Merged
1 task
@oliviertassinari oliviertassinari added the design This is about UI or UX design, please involve a designer label Aug 16, 2024
@mui mui deleted a comment from mui-bot Aug 16, 2024
@mui-bot

This comment was marked as resolved.

Sign in to view
@LukasTy LukasTy self-assigned this Aug 19, 2024
@LukasTy LukasTy changed the title [date picker] Improve clear action label [fields] Improve clear action label Aug 19, 2024
@LukasTy LukasTy added the feature: Keyboard editing Related to the pickers keyboard edition label Aug 19, 2024
@oliviertassinari oliviertassinari changed the title [fields] Improve clear action label [pickers][fields] Improve clear action label Sep 11, 2024
@oliviertassinari oliviertassinari merged commit 5cef050 into mui:master Sep 11, 2024
18 checks passed
@oliviertassinari oliviertassinari deleted the fix-input-clear branch September 11, 2024 17:47
@oliviertassinari
Copy link
Member Author

I move forward with this as #14587 seems to be the logical next step, solving:

If we go with only Clear, I'd say that we need to explore adding an aria relationship with the "Field" label to have something like Clear Birth date, button on screen readers. 💡 🤔

"Clear date" will never be clear if there are a couple of date input fields in the form 😁

arthurbalduini pushed a commit to arthurbalduini/mui-x that referenced this pull request Sep 30, 2024
@oliviertassinari
[pickers][fields] Improve clear action label (mui#14243)
7295764
@mbreadmachine mbreadmachine mentioned this pull request Oct 5, 2024
Closed
This was referenced Oct 5, 2024
Open
Open
Open
@mbreadmachine mbreadmachine mentioned this pull request Oct 6, 2024
Closed
This was referenced Oct 25, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@LukasTy LukasTy

Labels
component: pickers This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer feature: Keyboard editing Related to the pickers keyboard edition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliviertassinari @mui-bot @LukasTy