-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Introduce selectors with arguments #14236
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MBilalShafi
added
core
Infrastructure work going on behind the scenes
component: data grid
This is the name of the generic UI component, not the React module!
dx
Related to developers' experience
labels
Aug 16, 2024
Deploy preview: https://deploy-preview-14236--material-ui-x.netlify.app/ |
MBilalShafi
commented
Aug 16, 2024
11 tasks
romgrk
reviewed
Aug 22, 2024
romgrk
reviewed
Aug 22, 2024
romgrk
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as useGridSelectorV8
isn't public we can still refactor it if we find an issue with it later, so I'm good with merging this PR as it is.
arminmeh
approved these changes
Aug 22, 2024
MBilalShafi
changed the title
[DataGrid] Selectors with arguments
[DataGrid] Introduce selectors with arguments
Aug 22, 2024
This was referenced Sep 20, 2024
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: data grid
This is the name of the generic UI component, not the React module!
core
Infrastructure work going on behind the scenes
dx
Related to developers' experience
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #13757
Related discussion: https://github.com/mui/mui-x/pull/13757/files#r1686750062
Changelog
useGridSelector
,createSelector
, andcreateSelectorMemoized
named asuseGridSelectorV8
,createSelectorV8
, andcreateSelectorMemoizedV8
. Selectors created withcreateSelectorV8
orcreateSelectorMemoizedV8
must be used withuseGridSelectorV8
for them to work properly. These new variants will replace the existing props in v8.Todos