Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Use concurrency 1 in CircleCI #14110

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

JCQuintas
Copy link
Member

This should fix the issues where typescript checks are failing in CI

Circle CI only runs on 2 cpus: https://discuss.circleci.com/t/debugging-random-node-js-build-failures/39667

We should generally run CPU_COUNT - 1 concurrent processes, which leaves us at 1 for circleci

max-old-space-size has no effect on scripts that spawn multiple processes, so we can remove it in this instance.

@JCQuintas JCQuintas self-assigned this Aug 5, 2024
@JCQuintas JCQuintas added the scope: code-infra Specific to the core-infra product label Aug 5, 2024
@mui-bot
Copy link

mui-bot commented Aug 5, 2024

Deploy preview: https://deploy-preview-14110--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 7025464

@JCQuintas
Copy link
Member Author

Should resolve typescript OOM issues in CI on these PRs:

#13855
#13241

@flaviendelangle
Copy link
Member

flaviendelangle commented Aug 6, 2024

For #13855, I still have the issue for concurrency 1 :/

@JCQuintas
Copy link
Member Author

@flaviendelangle changes here were successful for the ts step, others are failing still though: #14109

Signed-off-by: Jose C Quintas Jr <[email protected]>
@JCQuintas JCQuintas enabled auto-merge (squash) August 6, 2024 08:42
@JCQuintas JCQuintas merged commit 4022241 into mui:master Aug 6, 2024
16 checks passed
@JCQuintas JCQuintas deleted the move-circleci-to-concurrency-1 branch August 6, 2024 08:59
@flaviendelangle
Copy link
Member

@JCQuintas I brought back all the demos and it seems to pass indeed
I think we needed both the concurrency change and the increase in resources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants