-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data grid] Add default reset value in row edit mode #14050
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelengelen
added
component: data grid
This is the name of the generic UI component, not the React module!
feature: Editing
Related to the data grid Editing feature
enhancement
This is not a bug, nor a new feature
labels
Jul 31, 2024
Deploy preview: https://deploy-preview-14050--material-ui-x.netlify.app/ |
arminmeh
reviewed
Sep 2, 2024
arminmeh
approved these changes
Sep 17, 2024
MBilalShafi
reviewed
Sep 17, 2024
packages/x-data-grid/src/hooks/features/editing/getDefaultCellValue.ts
Outdated
Show resolved
Hide resolved
packages/x-data-grid/src/hooks/features/editing/getDefaultCellValue.ts
Outdated
Show resolved
Hide resolved
…Value.ts Co-authored-by: Bilal Shafi <[email protected]> Signed-off-by: Michel Engelen <[email protected]>
michelengelen
requested review from
MBilalShafi
and removed request for
cherniavskii
September 17, 2024 12:59
MBilalShafi
approved these changes
Sep 17, 2024
arthurbalduini
pushed a commit
to arthurbalduini/mui-x
that referenced
this pull request
Sep 30, 2024
Signed-off-by: Michel Engelen <[email protected]> Co-authored-by: Bilal Shafi <[email protected]>
This was referenced Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: data grid
This is the name of the generic UI component, not the React module!
enhancement
This is not a bug, nor a new feature
feature: Editing
Related to the data grid Editing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the same default value resets as in #12216 and changes the test structure a bit to call the same tests for different scenarios.
Fixes #13628