Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump dayjs to ^1.11.13 #13919

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Bump dayjs to ^1.11.13 #13919

merged 2 commits into from
Oct 14, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 21, 2024 •
edited
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
dayjs (source) ^1.11.11 -> ^1.11.13 age adoption passing confidence

Release Notes

iamkun/dayjs (dayjs)

v1.11.13

Compare Source

v1.11.12

Compare Source

Bug Fixes

Configuration

📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Update of dependencies label Jul 21, 2024
@mui-bot
Copy link

mui-bot commented Jul 21, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-13919--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 511d6cb

@LukasTy LukasTy self-assigned this Jul 24, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 30, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 30, 2024
@renovate renovate bot changed the title Bump dayjs to ^1.11.12 Bump dayjs to ^1.11.13 Aug 20, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 26, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 26, 2024
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 28, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 25, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 25, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 7, 2024
@arthurbalduini arthurbalduini added the component: pickers This is the name of the generic UI component, not the React module! label Oct 11, 2024
arthurbalduini
arthurbalduini reviewed Oct 11, 2024
View reviewed changes
packages/x-date-pickers/src/DateCalendar/tests/timezone.DateCalendar.test.tsx
@@ -42,7 +42,9 @@ describe('<DateCalendar /> - Timezone', () => {

// Check the `onChange` value (uses timezone prop)
const actualDate = onChange.lastCall.firstArg;
expect(adapter.getTimezone(actualDate)).to.equal(timezone);
expect(adapter.getTimezone(actualDate)).to.equal(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we cannot rely on the timezone to test for dayJS since they are setting it to UTC when the value offset is zero

@arthurbalduini
Copy link
Member

It seems to fix #9653

@arthurbalduini arthurbalduini mentioned this pull request Oct 11, 2024
Open
2 tasks
@flaviendelangle
Copy link
Member

It seems to fix #9653

We need to test it in depth to make sure it does
But if it does, I'm in favor of bumping the minimal version of dayjs supported in the next major (maybe wait 2 months to make sure there is no massive regression introduced by this version).

@renovate Renovate
Copy link
Contributor Author

renovate bot commented Oct 11, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@LukasTy
Copy link
Member

LukasTy commented Oct 11, 2024

We need to test it in depth to make sure it does
But if it does, I'm in favor of bumping the minimal version of dayjs supported in the next major (maybe wait 2 months to make sure there is no massive regression introduced by this version).

@flav Do you think their (dayjs) fix makes sense, especially given other library behaviors?
Is it fine that any date with a +00:00 offset will internally be handled as a UTC date? 🤔

@flaviendelangle
Copy link
Member

Is it fine that any date with a +00:00 offset will internally be handled as a UTC date? 🤔

I have my doubts, but not enough knowledge to know if this will cause problem or not
Hopefully not, but that's why I'd wait for the end of the alpha before bumping the dep.

@LukasTy
Copy link
Member

LukasTy commented Oct 12, 2024

Hopefully not, but that's why I'd wait for the end of the alpha before bumping the dep.

Gotcha. Just confirming. Do you mean the peer dep?
We can clearly keep that bump for later. 👌

@flaviendelangle
Copy link
Member

Gotcha. Just confirming. Do you mean the peer dep?

Yes

LukasTy
LukasTy approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this @arthurbalduini! 🙏

@LukasTy LukasTy merged commit 95d67b6 into master Oct 14, 2024
20 checks passed
@LukasTy LukasTy deleted the renovate/dayjs-1.x branch October 14, 2024 08:57
@LukasTy LukasTy mentioned this pull request Oct 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthurbalduini arthurbalduini arthurbalduini left review comments

@LukasTy LukasTy LukasTy approved these changes

@flaviendelangle flaviendelangle Awaiting requested review from flaviendelangle

Assignees

@LukasTy LukasTy

Labels
component: pickers This is the name of the generic UI component, not the React module! dependencies Update of dependencies size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mui-bot @arthurbalduini @flaviendelangle @LukasTy