[TreeView] Add utility function to check if an optional plugin is present #13788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
the
component: tree view
flaviendelangle
commented
Jul 10, 2024
| @@ -0,0 +1,12 @@ | |||
| import { TreeViewAnyPluginSignature, TreeViewInstance, TreeViewPlugin } from '../models'; | |||
|
|
|||
| export const hasPlugin = < | |||
There was a problem hiding this comment.
I can't have this inside useTreeViewOptionalPlugins because instance needs to be a param in order to infer its shape.
Otherwise we would need to do instance.hasPlugin(instance, plugin) which is worse IMHO.
flaviendelangle
commented
Jul 10, 2024
| @@ -142,7 +143,9 @@ export const useTreeViewKeyboardNavigation: TreeViewPlugin< | |||
| const nextItem = getNextNavigableItem(instance, itemId); | |||
| if (nextItem) { | |||
| event.preventDefault(); | |||
| instance.focusItem(event, nextItem); | |||
| if (hasPlugin(instance, useTreeViewFocus)) { | |||
There was a problem hiding this comment.
I used this plugin as an example but I will remove before merging 👌
|
Deploy preview: https://deploy-preview-13788--material-ui-x.netlify.app/ |
6 tasks
noraleonte
approved these changes
Jul 11, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13777