[release] v7.8.0 #13655
[release] v7.8.0 #13655
Conversation
|
Deploy preview: https://deploy-preview-13655--material-ui-x.netlify.app/ |
Co-authored-by: Bilal Shafi <[email protected]> Co-authored-by: Flavien DELANGLE <[email protected]> Co-authored-by: Jose C Quintas Jr <[email protected]> Signed-off-by: Kenan Yusuf <[email protected]>
|
Had to clean my node_modules 🤔 |
CHANGELOG.md
Outdated
| - 📈 Support Date data on the BarChart component | ||
| - 🖱️ Support modifying the expansion trigger on the Tree View components | ||
| - ↕️ Support custom column sort icons on the Data Grid | ||
| - 📝 Add "Overlays" section to the Data Grid documentation |
There was a problem hiding this comment.
It's up for debate, but I think we have too many highlights and not all of them are impact-full enough to be here.
Do we usually add highlights for new doc sections?
Same for the Date data support on BarChart, it makes it look like a major new feature but the PR is super small (#13471)
I could even drop the custom expansion trigger highlight, they are all super small additions compared with the data source.
There was a problem hiding this comment.
I'm not too sure what constitutes as impactful enough yet, so happy to take the consensus here.
There was a problem hiding this comment.
I'm not 100% confident saying which features of other teams is impactful enough.
For eXplore, I'd say nothing this week, on a small release I would keep the "expansion trigger" but it's more to have something to say.
There was a problem hiding this comment.
I'd agree that not adding super-smaller changes to the highlights would put more emphasis on the comparatively larger feature with a much higher anticipated audience. 👍
But I am not sure which ones to keep and which ones to remove.
We could also split the data source highlight into multiple lines and add a bit more detail to improve the emphasis. 🤔
There was a problem hiding this comment.
Totally agree that the data source is worth a code snippet 👌 (usually we use a GIF but it's not really a design feature)
There was a problem hiding this comment.
Same for the Date data support on BarChart, it makes it look like a major new feature but the PR is super small
I don't think the PR size matters. I added it in the changelog because it impacts how charts are rendered if you use Date object. I theory everybody should be happy about this modification, but I prefer to have a highlight to let user see their is a modification
There was a problem hiding this comment.
OK if you think the Date support is worth highlighting, you clearly know better than me 👍
Co-authored-by: Alexandre Fauquette <[email protected]> Signed-off-by: Kenan Yusuf <[email protected]>
Co-authored-by: Lukas <[email protected]> Signed-off-by: Kenan Yusuf <[email protected]>
@JCQuintas I haven't been able to replicate this - can anyone else? If so, please let me know how. |
Co-authored-by: Lukas <[email protected]> Signed-off-by: Kenan Yusuf <[email protected]>
Signed-off-by: Kenan Yusuf <[email protected]> Co-authored-by: Bilal Shafi <[email protected]> Co-authored-by: Flavien DELANGLE <[email protected]> Co-authored-by: Jose C Quintas Jr <[email protected]> Co-authored-by: Alexandre Fauquette <[email protected]> Co-authored-by: Lukas <[email protected]>
Signed-off-by: Kenan Yusuf <[email protected]> Co-authored-by: Bilal Shafi <[email protected]> Co-authored-by: Flavien DELANGLE <[email protected]> Co-authored-by: Jose C Quintas Jr <[email protected]> Co-authored-by: Alexandre Fauquette <[email protected]> Co-authored-by: Lukas <[email protected]>
No description provided.