Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[l10n] Improve Korean (ko-KR) locale #13651

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Conversation

100pearlcent
Copy link
Contributor

I haven't found proper word for meridiem in Korean tho.
I'm open to any suggestions for improvement.

@mui-bot
Copy link

mui-bot commented Jun 28, 2024

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running pnpm l10n
  • Clean files with pnpm prettier.

Deploy preview: https://deploy-preview-13651--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 1df7e40

@LukasTy LukasTy added l10n localization component: pickers This is the name of the generic UI component, not the React module! labels Jun 28, 2024
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 🙏

I haven't found proper word for meridiem in Korean tho.
I'm open to any suggestions for improvement.

I don't see a clear translation for it as well.
It's currently only used as an aria-label for TimeField section, so, possibly not a huge problem not having it translated. 🤞

Please run pnpm l10n && pnpm prettier to fix CI issues. 😉

@JCQuintas
Copy link
Member

JCQuintas commented Jun 28, 2024

Google suggests 메리디엠 (melidiem) which is probably a direct borrowing from latin, since english's AM/PM day division is also from there, eg: ante meridiem, it probably makes sense, unless there is a native normalised word for that division already.

Though I have no knowledge of the Korean language myself. 😅

@flaviendelangle flaviendelangle merged commit 0794a25 into mui:master Jul 16, 2024
17 checks passed
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants