Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Improve the documentation of the picker's onChange and onAccept props #13543

Merged
merged 6 commits into from
Jul 17, 2024
Merged

[docs] Improve the documentation of the picker's onChange and onAccept props #13543

merged 6 commits into from
Jul 17, 2024

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Jun 19, 2024 •
edited
Loading

Follow up on #13511

@flaviendelangle flaviendelangle added docs Improvements or additions to the documentation component: pickers This is the name of the generic UI component, not the React module! labels Jun 19, 2024
@flaviendelangle flaviendelangle self-assigned this Jun 19, 2024
@mui-bot
Copy link

mui-bot commented Jun 19, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-13543--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against 2e053ec

@flaviendelangle flaviendelangle marked this pull request as ready for review June 20, 2024 06:47
LukasTy
LukasTy approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The improvement looks great! 👏
I'm just not sure about the heading structure. 🙈
Maybe we could avoid the additional 5th level nesting?

docs/data/date-pickers/lifecycle/lifecycle.md Outdated Show resolved Hide resolved
docs/data/date-pickers/lifecycle/lifecycle.md Outdated Show resolved Hide resolved
arthurbalduini
arthurbalduini approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@arthurbalduini arthurbalduini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great addition 🚀

LukasTy
LukasTy reviewed Jul 17, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! 👍

docs/data/date-pickers/lifecycle/lifecycle.md Show resolved Hide resolved
docs/data/date-pickers/lifecycle/lifecycle.md Outdated Show resolved Hide resolved
@LukasTy LukasTy mentioned this pull request Jul 17, 2024
Merged
LukasTy
LukasTy approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that mui/material-ui#42979 has been merged, feel free to revert to using code in the headings if you think they better suit the use case.
The spacing problem will be fixed with following monorepo bump. 😉

@flaviendelangle
Copy link
Member Author

I'm fine removing the code anyway 👍

@flaviendelangle flaviendelangle merged commit b40d511 into mui:master Jul 17, 2024
17 checks passed
@flaviendelangle flaviendelangle deleted the context-doc branch July 17, 2024 12:31
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
@flaviendelangle @DungTiger
[docs] Improve the documentation of the picker's onChange and `onAc…
4e8da49 
…cept` props (mui#13543)
@alhabib5565 alhabib5565 mentioned this pull request Aug 19, 2024
Open
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@flaviendelangle @thomasmoon
[docs] Improve the documentation of the picker's onChange and `onAc…
fa53576 
…cept` props (mui#13543)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthurbalduini arthurbalduini arthurbalduini approved these changes

@LukasTy LukasTy LukasTy approved these changes

Assignees

@flaviendelangle flaviendelangle

Labels
component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flaviendelangle @mui-bot @LukasTy @arthurbalduini