[charts] Prepare ChartContainerPro for future Zoom changes
#13532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCQuintas
added
enhancement
|
Deploy preview: https://deploy-preview-13532--material-ui-x.netlify.app/ |
JCQuintas
force-pushed
the
prepare-chart-container-pro
branch
from
522d4d9
to
c5595c0
Compare
packages/x-charts-pro/src/ChartContainerPro/ChartContainerPro.tsx
Outdated
Show resolved
Hide resolved
packages/x-charts-pro/src/ChartContainerPro/ChartContainerPro.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Flavien DELANGLE <[email protected]> Signed-off-by: Jose C Quintas Jr <[email protected]>
| @@ -17,12 +17,10 @@ const ResponsiveChartContainerPro = React.forwardRef(function ResponsiveChartCon | |||
| const { width: inWidth, height: inHeight, ...other } = props; | |||
| const [containerRef, width, height] = useChartContainerDimensions(inWidth, inHeight); | |||
|
|
|||
| useLicenseVerifier('x-charts-pro', releaseInfo); | |||
There was a problem hiding this comment.
This could effectively be moved in the the ChartContainerPro, but I do not see where you added it back
There was a problem hiding this comment.
Oops. I was tinkering with the license things 😅
There was a problem hiding this comment.
Though the Watermark component runs it already, would we still need it?
export function Watermark(props: WatermarkProps) {
const { packageName, releaseInfo } = props;
const licenseStatus = useLicenseVerifier(packageName, releaseInfo);There was a problem hiding this comment.
the Watermark component runs it already
I did not know
would we still need it
Could be nice in the container since it does not have Watermark, and adding the watermark could add complication
alexfauquette
approved these changes
Jun 19, 2024
This was referenced Jul 13, 2024
This was referenced Jul 20, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
Signed-off-by: Jose C Quintas Jr <[email protected]> Co-authored-by: Flavien DELANGLE <[email protected]>
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Signed-off-by: Jose C Quintas Jr <[email protected]> Co-authored-by: Flavien DELANGLE <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChartContainerProfor Zoom changesrelated #13405