Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TreeView] Support item reordering using drag and drop #12213

Merged
merged 45 commits into from
Jul 31, 2024

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Feb 26, 2024

@flaviendelangle flaviendelangle self-assigned this Feb 26, 2024
@flaviendelangle flaviendelangle added breaking change component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! labels Feb 26, 2024
@flaviendelangle flaviendelangle marked this pull request as draft February 26, 2024 13:33
@mui-bot
Copy link

mui-bot commented Feb 26, 2024

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 28, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Feb 29, 2024
Copy link

github-actions bot commented Mar 4, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Mar 4, 2024
Copy link

github-actions bot commented Mar 6, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 6, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 11, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 19, 2024
@flaviendelangle flaviendelangle changed the base branch from next to master March 21, 2024 14:10
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 25, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 25, 2024
@flaviendelangle flaviendelangle changed the title [TreeView] POC: Drag & drop [TreeView] Add support for drag and drop Mar 28, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 28, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 28, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 3, 2024
Copy link

github-actions bot commented Apr 3, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 16, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 22, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 23, 2024
Copy link
Contributor

@noraleonte noraleonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on this huge effort! 🎉 It's looking great! 🔥

@flaviendelangle flaviendelangle merged commit 995fccc into mui:master Jul 31, 2024
18 checks passed
@flaviendelangle flaviendelangle deleted the drag-and-drop-tree-view branch July 31, 2024 11:55
@LukasTy LukasTy added new feature New feature or request plan: Pro Impact at least one Pro user labels Aug 1, 2024
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firstly, I'm very sorry for a late review. 🙈

Congrats on such an awesome feature and superb implementation, great job! 👍 💯

A few comments:

  • I believe that clicking Esc should cancel the dragging and releasing the mouse afterwards should not finish it.
  • It would be nice to avoid the animation of the dragging item returning (floating) to the original place before finishing the dragging action.

@flaviendelangle
Copy link
Member Author

I opened a PR for the env check because it's trivial to fix and doing it before the release is better

For the rest we can do a follow up

I believe that clicking Esc should cancel the dragging and releasing the mouse afterwards should not finish it.

Fully agree, I'll fix that

It would be nice to avoid the animation of the dragging item returning (floating) to the original place before finishing the dragging action.

Could you record your screen with this behavior visible to be sure I'm understand what you are referring to?

@LukasTy
Copy link
Member

LukasTy commented Aug 1, 2024

I believe that clicking Esc should cancel the dragging and releasing the mouse afterwards should not finish it.

Fully agree, I'll fix that

Makes sense. 👌

Could you record your screen with this behavior visible to be sure I'm understand what you are referring to?

Screen.Recording.2024-08-01.at.16.54.00.mov

I'm circling over the somewhat strange behavior—resembling a canceled drag. 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! new feature New feature or request plan: Pro Impact at least one Pro user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tree view] Add drag & drop support
6 participants