[docs-infra] Test new vale config sharing #12132
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
alexfauquette
commented
Feb 20, 2024
| .github/styles/ |
There was a problem hiding this comment.
Maybe to simplify adding custom style just for X. But not sure we want to encourage such a thing
Suggested change
| .github/styles/ | |
| .github/styles/Google | |
| .github/styles/writing-rules |
alexfauquette
commented
Feb 20, 2024
.vale.ini
Outdated
| @@ -2,20 +2,13 @@ | |||
| StylesPath = .github/styles | |||
| MinAlertLevel = suggestion | |||
|
|
|||
| Packages = Google | |||
| Packages = Google, https://github.com/alexfauquette/material-ui/raw/comon-vale-config/docs/writing-rules.zip | |||
There was a problem hiding this comment.
To update after mui/material-ui#41176 is merged
alexfauquette
commented
Feb 20, 2024
package.json
Outdated
| @@ -86,7 +86,7 @@ | |||
| "@mnajdova/enzyme-adapter-react-18": "^0.2.0", | |||
| "@mui/icons-material": "^5.15.9", | |||
| "@mui/material": "^5.15.9", | |||
| "@mui/monorepo": "https://github.com/mui/material-ui.git#master", | |||
| "@mui/monorepo": "https://github.com/alexfauquette/material-ui.git#comon-vale-config", | |||
github-actions
bot
removed
the
PR: out-of-date
alexfauquette
changed the title
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test mui/material-ui#41176