Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data grid] Use readonly array result for getTreeDataPath #11743

Merged
merged 2 commits into from
Aug 22, 2024
Merged

[data grid] Use readonly array result for getTreeDataPath #11743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cc32b1
[DataGridPro] Use readonly array result for getTreeDataPath.
pcorpet Apr 26, 2024
d8f6370
ci: run (empty commit)
romgrk Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/x-data-grid-pro/src/models/dataGridProProps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ interface DataGridProRegularProps<R extends GridValidRowModel> {
* @param {R} row The row from which we want the path.
* @returns {string[]} The path to the row.
*/
getTreeDataPath?: (row: R) => string[];
getTreeDataPath?: (row: R) => readonly string[];
}

export interface DataGridProPropsWithoutDefaultValue<R extends GridValidRowModel = any>
Expand Down
2 changes: 1 addition & 1 deletion packages/x-data-grid-pro/src/tests/treeData.DataGridPro.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ describe('<DataGridPro /> - Tree data', () => {
]);
setProps({
getTreeDataPath: (row) => [...row.name.split('.').reverse()],
} as DataGridProProps);
} as Pick<DataGridProProps, 'getTreeDataPath'>);
expect(getColumnValues(1)).to.deep.equal([
'A',
'A.A',
Expand Down