[pickers] Avoid deeper than 2nd level imports #11588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasTy
added
component: pickers
|
Deploy preview: https://deploy-preview-11588--material-ui-x.netlify.app/ |
flaviendelangle
approved these changes
Jan 5, 2024
| @@ -32,14 +32,11 @@ import { | |||
| } from '@mui/x-date-pickers/StaticDateTimePicker'; | |||
| import { DateOrTimeView } from '@mui/x-date-pickers/models'; | |||
| import { PickersShortcutsItem } from '@mui/x-date-pickers/PickersShortcuts'; | |||
| import { DateRange } from '@mui/x-date-pickers-pro/internals/models'; | |||
| import { DateRange } from '@mui/x-date-pickers-pro'; | |||
There was a problem hiding this comment.
I need to move this interface to @mui/x-date-pickers-pro/models in a follow up, it's a shame to have to use the root import here but it's the best we can do for now
There was a problem hiding this comment.
Were you considering doing a follow-up?
I can do it as well. 👍
There was a problem hiding this comment.
Yes that's something I wanted to do for some time 👍
I'll handle it next week
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #9528
Refactor the existing imports with depth >2 In an effort to avoid future problems when we disallow them.