Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGridPro] Autosize columns #10180
[DataGridPro] Autosize columns #10180
Changes from 14 commits
58b81d8
fbacef8
6eb4c33
7bb5eed
fbd645e
fec64c5
6db3879
3819972
b423465
93b135e
aba5388
8d899d0
9c723e5
1967163
8b24ed1
3e8edb8
34142a0
978fbc1
52986f2
310bbe0
b8c1a82
2ff9ecb
1db9646
dd165c9
1d14a37
f272533
a0cd6bb
f9f2d02
ae8f7b9
e35854b
df10cc3
7c5ce54
675d094
e34ac05
9bc48b6
2c8af8b
bbe3ab4
7a08e0a
386ea98
0e549df
29134e9
3c7fe6a
d69754d
afea006
ea7a6b6
6e3df33
b427a75
9401db1
8f8261c
7bda608
c04048f
1f2b19f
0fdad6d
f590190
c454521
dc5e4c9
c2d66ef
4efe879
bc7eb22
600a4f2
9d5d1de
23323c3
c8b52c0
0556e3f
0d5d9a8
486b522
581e3f6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional: To me, excluding outliers is an amazing feature that should be expected by most of users to be turned on by default. How about keeping the naming to match
includeHeaders
but having it turned on by default (by keeping the default value tofalse
)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matching name: Not sure, I have a slight preference for
excludeOutliers
for some reason.Default value: Yes, excluding outliers is an interesting behavior. I'd be ok with having it on by default. @cherniavskii Any opinion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've included both these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for being late to the party, but I'd still like to share my opinion 🙃
While excluding outliers is a cool feature, I would expect autosizing to include outliers by default, because otherwise, it feels like autosizing doesn't work as expected (some of the values might still be truncated).
Would be great to have the
autosizeOptions
documented along with the default values 👍🏻There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing we overlooked is the experimental flag (or
unstable_
prefix) for the new feature so that we can iterate on default behavior and/or prop names 😅cc @MBilalShafi @romgrk @joserodolfofreitas