Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Alternative column header group design? #9162

Closed
oliviertassinari opened this issue May 30, 2023 · 2 comments
Closed

[data grid] Alternative column header group design? #9162

oliviertassinari opened this issue May 30, 2023 · 2 comments
Assignees
Labels
component: data grid This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process design This is about UI or UX design, please involve a designer feature: Column groups Related to the data grid Column groups feature

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented May 30, 2023

Steps to reproduce 🕹

Link to live example:

Steps:

  1. Open https://mui.com/x/react-data-grid/column-groups/

Current behavior 😯

Screenshot 2023-05-30 at 16 29 15

Expected behavior 🤔

Frame 1 (1)

It's about using solid full horizontal bars, so headers feel consistent, but adding a vertical bar when it's needed to disambiguate. This should bring a bit more contrast.

Context 🔦

I can't make sense of the current design of the column group. I'm confused about which column end and starts where. The underline doesn't feel enough, e.g.

Screenshot 2023-05-30 at 16 32 04

Taken from #5133 (comment)

Your environment 🌎

No response

Order ID or Support key 💳 (optional)

No response

@oliviertassinari oliviertassinari added component: data grid This is the name of the generic UI component, not the React module! design: ui feature: Column groups Related to the data grid Column groups feature design: material This is about Material Design, please involve a visual or UX designer in the process labels May 30, 2023
@oliviertassinari oliviertassinari added design This is about UI or UX design, please involve a designer and removed design: ui labels Aug 18, 2023
@KenanYusuf KenanYusuf self-assigned this Jul 9, 2024
Copy link

github-actions bot commented Sep 3, 2024

⚠️ This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@oliviertassinari: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Sep 3, 2024

Linking the design exploration for the future: https://www.figma.com/design/rPwfaFijKseEDWpJYg46rA/Column-headers?node-id=0-1&node-type=CANVAS&t=iBsRSbPXWokxOnQo-0.

The result: https://deploy-preview-14293--material-ui-x.netlify.app/x/react-data-grid/column-groups/. Yeah OK, this feels better.

I'm not 100% convinced about the experience but it might be best to wait for user feedback here: it's unclear we can do better or even if it's worth allocating time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process design This is about UI or UX design, please involve a designer feature: Column groups Related to the data grid Column groups feature
Projects
Status: Done
Development

No branches or pull requests

2 participants