-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data grid] Improve column separators to display ability to resize columns #7268
Comments
The proposed design makes sense to me 👍. In this example, I feel like I would be able to resize each column but I'm not. It feels like the proposed design of Gerda would solve the problem: https://mui.com/x/react-data-grid/#mit-version Minor. I think that it could be interesting to see what's the UI for when the mouse down is pressed. I wonder if it's not a bit off today: 1. is the resize handle tall enough, it can be hidden behind the cursor. 2. is the color contrasting enough. This a quick benchmark, not sure. None feels like they make a major difference. |
I tried to validate the idea, here's a codesandbox with comparisons between different features: https://codesandbox.io/s/purple-shadow-c8l2xk?file=/demo.tsx
I've made it a bit taller to test if it resolves the concerns. What do you think? I really liked the new implementation, especially the variant with header filters and how it defines the boundaries of each cell. Regarding column groups, I think this one combined with the idea shown in #9162 could be a great improvement. CC @gerdadesign |
@MBilalShafi Great, thanks for looking into it! A few design execution feedback:
Screen.Recording.2023-06-01.at.14.37.40.mov
But I don't see how we can pull it off without forcing a background color on the whole data grid. I'm not sure this potential UX win is worth the DX customization pain.
|
@joserodolfofreitas: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey. |
Summary 💡
The column headers separators present no distinguishable difference between columns that can be resized and columns that don't. This is a follow-up on #1623.
On #7067, we started exploring ways to make this difference clear, but there're also some challenges to validate and other solutions to explore.
Examples 🌈
Motivation 🔦
Design
The text was updated successfully, but these errors were encountered: