Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] v7 API: Make the behavior of GridColDef flags consistent #10552

Closed
5 tasks done
Tracked by #7902
MBilalShafi opened this issue Oct 2, 2023 · 1 comment · Fixed by #11680
Closed
5 tasks done
Tracked by #7902

[data grid] v7 API: Make the behavior of GridColDef flags consistent #10552

MBilalShafi opened this issue Oct 2, 2023 · 1 comment · Fixed by #11680
Assignees
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! umbrella For grouping multiple issues to provide a holistic view v7.x

Comments

@MBilalShafi
Copy link
Member

MBilalShafi commented Oct 2, 2023

The main goal to address:
Make the colDef flags work like this, if a flag is passed as false, it should only be disallowed from the UI and not using the API.

For example if for a column, colDef.sortable is false. The sorting won't work using the grid UI, however apiRef.current.sortColumn will update the sorting as expected.

Context: #10180 (comment)

The flags which ✅ already work as expected:

  • ✅ hideable
  • ✅ resizable (auto-sizing works like so, basic resizing has no public API method available)

The flags/items to update

@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 2, 2023
@MBilalShafi MBilalShafi added breaking change component: data grid This is the name of the generic UI component, not the React module! v7.x and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 2, 2023
@github-project-automation github-project-automation bot moved this to 🆕 Needs refinement in MUI X Data Grid Oct 17, 2023
@cherniavskii
Copy link
Member

This change should be communicated in the docs:

@cherniavskii cherniavskii moved this from 🆕 Needs refinement to 📋 Backlog in MUI X Data Grid Oct 17, 2023
@cherniavskii cherniavskii moved this from 📋 Backlog to 🔖 Ready in MUI X Data Grid Oct 17, 2023
@MBilalShafi MBilalShafi self-assigned this Nov 29, 2023
@MBilalShafi MBilalShafi moved this from 🔖 Ready to 🏗 In progress in MUI X Data Grid Jan 4, 2024
@MBilalShafi MBilalShafi changed the title [datagrid] v7 API: Make the behavior of GridColDef flags consistent [data grid] v7 API: Make the behavior of GridColDef flags consistent Jan 14, 2024
@MBilalShafi MBilalShafi added the umbrella For grouping multiple issues to provide a holistic view label Jan 15, 2024
MBilalShafi added a commit to MBilalShafi/mui-x that referenced this issue Jan 16, 2024
@cherniavskii cherniavskii moved this from 🏗 In progress to ✅ Done in MUI X Data Grid Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! umbrella For grouping multiple issues to provide a holistic view v7.x
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants