[Snackbar] Implement the component on the next branch #7059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
component: snackbar
oliviertassinari
commented
Jun 5, 2017
| @@ -128,6 +127,10 @@ IconButton.propTypes = { | |||
| */ | |||
| className: PropTypes.string, | |||
| /** | |||
| * Determines the color of the `IconButton`. | |||
| */ | |||
| color: PropTypes.oneOf(['inherit']), | |||
There was a problem hiding this comment.
I feel like this pattern is better and plan on migrating the whole code base.
|
@oliviertassinari Looks great! Do you plan to add tests before merging? |
|
@mbrookes Yeah, I do. Just an early PR to run the CI. |
|
Is this available inside npm package material-ui@next? @oliviertassinari |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used @josulliv101 PR as a starting point.
Closes #6913
Closes #6835
Closes #6269
Closes #5218
Closes #3860
Closes #3186
Closes #2835
Closes #2826