[docs] Fix FlatButton example Firefox behavior #5933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muibot
added
PR: Needs Review
PR: needs revision
mbrookes
removed
the
PR: needs revision
oliviertassinari
requested changes
Jan 14, 2017
| @@ -32,6 +40,7 @@ const FlatButtonExampleComplex = () => ( | |||
| href="https://github.com/callemall/material-ui" | |||
| target="_blank" | |||
| label="GitHub Link" | |||
| style={styles.button} | |||
There was a problem hiding this comment.
Looks like we don't need that property here.
| @@ -4,6 +4,9 @@ import FontIcon from 'material-ui/FontIcon'; | |||
| import ActionAndroid from 'material-ui/svg-icons/action/android'; | |||
|
|
|||
| const styles = { | |||
| button: { | |||
| verticalAlign: 'top', | |||
There was a problem hiding this comment.
middle to follow the align applied with a link (<a />).
| @@ -4,6 +4,9 @@ import FontIcon from 'material-ui/FontIcon'; | |||
| import ActionAndroid from 'material-ui/svg-icons/action/android'; | |||
|
|
|||
| const styles = { | |||
| button: { | |||
There was a problem hiding this comment.
I think that we can rename that key. uploadButton sound better.
| @@ -4,6 +4,9 @@ import FontIcon from 'material-ui/FontIcon'; | |||
| import ActionAndroid from 'material-ui/svg-icons/action/android'; | |||
|
|
|||
| const styles = { | |||
| button: { | |||
| verticalAlign: 'top', | |||
| }, | |||
| imageInput: { | |||
There was a problem hiding this comment.
uploadInput sounds better too here.
oliviertassinari
added
bug 🐛
mbrookes
added
component: FlatButton
and removed
PR: needs revision
oliviertassinari
approved these changes
Jan 16, 2017
oliviertassinari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix of Flat button example in Firefox
Issue link
Vertical-align added to keep them aligned properly
Closes #5916