Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[utils] Add documentation to useForkRef #44410

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

JCQuintas
Copy link
Member

Add documentation to explain what the useForkRef actually does and is useful for.

@JCQuintas JCQuintas added docs Improvements or additions to the documentation package: utils Specific to the @mui/utils package labels Nov 14, 2024
@JCQuintas JCQuintas self-assigned this Nov 14, 2024
@mui-bot
Copy link

mui-bot commented Nov 14, 2024

Netlify deploy preview

https://deploy-preview-44410--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against d4c8de4

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👌

@JCQuintas JCQuintas merged commit 2224b22 into mui:master Nov 15, 2024
21 checks passed
@oliviertassinari oliviertassinari added package: base-ui Specific to @mui/base core Infrastructure work going on behind the scenes and removed docs Improvements or additions to the documentation labels Nov 15, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 15, 2024

Fair enough. Per https://www.notion.so/mui-org/engineering-mui-utils-purpose-9a9fc9da3a004864b6c4e1f4d1f24f95?p=6af37c204f624505b8ef6b1fb571366a we likely want to keep it private cc @michaldudak, but having some docs for developer internally is cool 👍.

@JCQuintas
Copy link
Member Author

JCQuintas commented Nov 15, 2024

Yeah, my goal was more for internal use, as I was using it by "copy/paste" and I had to go to the source to understand what it does exactly. This small doc should help future "me"s 😆

@oliviertassinari
Copy link
Member

@JCQuintas I pushed the docs a bit further #44424, I was a bit confused with what I read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes package: base-ui Specific to @mui/base package: utils Specific to the @mui/utils package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants