[poc] Support a version of Material UI without CSS in JS #44407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
added
the
proof of concept
Netlify deploy previewhttps://deploy-preview-44407--material-ui.netlify.app/ Bundle size reportBundle size will be reported once CircleCI build #767890 finishes. |
mnajdova
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR serves as a proof of concept of how we can build Material UI components using CSS modules, and then allow CSS in JS users to use all of the previously available APIs, like sx prop, styleOverrides etc. On the other hand, for people that care about performance or want to use plain CSS, they don't have to pay any penalty of bundle size or performance that comes from using CSS in JS.
CodeSandbox using Emotion: https://codesandbox.io/p/devbox/vite-react-forked-47ffsv (using the default @mui/styled-engine package)
CodeSandbox using only CSS modules: https://codesandbox.io/p/devbox/ssvrx2 (using the CSS modules only supported package @mui/styled-engine-noop - check vite.config.js)