[material-ui] Prevent ownerState propagation for transition slots
#44401
+58
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-44401--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
ZeeshanTamboli
changed the title
ownerState propagation in accordion transition slotownerState propagation for transition slots
ZeeshanTamboli
changed the title
ownerState propagation for transition slotsownerState propagation for transition slots
| @@ -98,9 +98,16 @@ export default function useSlot< | |||
| * e.g. Autocomplete's listbox uses Popper + StyledComponent | |||
| */ | |||
| internalForwardedProps?: any; | |||
| /** | |||
| * If `false`, does not append `ownerState` prop to the element. | |||
| * | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while investigating an issue—check the console error about
ownerState.Before: Sandbox
After: Sandbox
You can also see it in the local Accordion docs at
http://localhost:3000/material-ui/react-accordion/.The workaround in #40418 was removed in favor of #41187, but #41187 doesn’t handle custom transition slots like Fade and Zoom.
This PR introduces a new
shouldAppendOwnerStateoption inuseSlot, preventingownerStatefrom being appended unnecessarily, instead of appending and then removing it.