[material-ui][pigment-css] Support project without enabling CSS variables #44171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
package: material-ui
brijeshb42
approved these changes
Oct 21, 2024
Netlify deploy previewhttps://deploy-preview-44171--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #43750
Root cause
The
.toRuntimeSourceis required in the theme for some components that access runtime theme's transitions (e.g. Slide) but the property only exist when using CSS theme variables.Pigment CSS should work with any theme, so the fix is to also add the property to the theme when CSS variables is not enabled.