[code-infra] Widen eslint file patterns #44148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-44148--material-ui.netlify.app/ Bundle size report |
Janpot
commented
Oct 18, 2024
| { | ||
| files: ['docs/data/base/components/modal/UseModal.js'], |
There was a problem hiding this comment.
Too fine grained, moving this into the file itself
Janpot
commented
Oct 18, 2024
| @@ -380,6 +368,13 @@ module.exports = /** @type {Config} */ ({ | |||
| { | |||
| files: ['packages/*/src/**/*.tsx'], | |||
| excludedFiles: '*.spec.tsx', | |||
| rules: { | |||
| 'react/prop-types': 'off', | |||
There was a problem hiding this comment.
This one got lumped in with the one below, but should only apply to tsx files
Janpot
commented
Oct 18, 2024
Janpot
changed the title
I think it's for enforcing translation of docs component which were initially only written in JS. Could you open a distinct PR to enable it also on ts files. I will give a look to fix what's needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Widen javascript/typescript rules to all possible extensions. Avoids situations like #44143 (comment)
Question for @mui/docs-infra: what with
material-ui/no-hardcoded-labels, it applies only to js files and in many ts files there are violations. Should we fix those cases? Or remove the rule altogether?