Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][TextField] Dynamically modify the eye password button aria-label #44122

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

ChinoUkaegbu
Copy link
Contributor

@ChinoUkaegbu ChinoUkaegbu commented Oct 16, 2024

Closes #44109

Demo:

Password_Icon_Aria_Change.mp4

Tagging @mnajdova for review

@mui-bot
Copy link

mui-bot commented Oct 16, 2024

Netlify deploy preview

https://deploy-preview-44122--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against ece7123

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the quick fix :)

@mnajdova mnajdova changed the title docs: Dynamically modify the password icon aria-label [docs][TextField] Dynamically modify the eye password button aria-label Oct 16, 2024
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation accessibility a11y component: text field This is the name of the generic UI component, not the React module! labels Oct 16, 2024
@mnajdova mnajdova merged commit 708dcec into mui:master Oct 17, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y component: text field This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs][TextField][a11y] Dynamically modify the value of the aria-label on the eye button (password field)
4 participants