Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Mark the Hidden component as deprecated in the sidenav #44068

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

jimmycallin
Copy link
Contributor

@jimmycallin jimmycallin commented Oct 11, 2024

The Grid component had a nice deprecated label in the navigation drawer, while Hidden didn't despite being deprecated, so added it :)

Preview: https://deploy-preview-44068--material-ui.netlify.app/material-ui/react-hidden/

@siriwatknp
Copy link
Member

Nice suggestion!

@siriwatknp siriwatknp added the docs Improvements or additions to the documentation label Oct 11, 2024
@siriwatknp
Copy link
Member

@jimmycallin Can you update the branch with the latest master? somehow I could not checkout this branch locally.

@oliviertassinari oliviertassinari changed the title Mark the Hidden component as deprecated in the navigation drawer [docs] Mark the Hidden component as deprecated in the sidenav Oct 11, 2024
@mui-bot
Copy link

mui-bot commented Oct 11, 2024

Netlify deploy preview

https://deploy-preview-44068--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 7d6c907

@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 11, 2024

This made me realize that we never created an issue to keep track of the end of this component, never too late, #44073.

@aarongarciah aarongarciah enabled auto-merge (squash) October 22, 2024 13:49
@aarongarciah aarongarciah merged commit bcb158e into mui:master Oct 22, 2024
22 checks passed
@jimmycallin jimmycallin deleted the patch-1 branch October 22, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants