Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][material-ui] Fix #43986: Incorrect React useState Example on Toggle Button #43987

Merged
merged 6 commits into from
Oct 8, 2024
Merged

[docs][material-ui] Fix #43986: Incorrect React useState Example on Toggle Button #43987

merged 6 commits into from
Oct 8, 2024

Conversation

barrownicholas
Copy link
Contributor

@barrownicholas barrownicholas mentioned this pull request Oct 4, 2024
Closed
@barrownicholas barrownicholas changed the title Fix #43986: Incorrect React useState Example on Toggle Button [docs] Fix #43986: Incorrect React useState Example on Toggle Button Oct 4, 2024
@barrownicholas barrownicholas changed the title [docs] Fix #43986: Incorrect React useState Example on Toggle Button [docs][material-ui] Fix #43986: Incorrect React useState Example on Toggle Button Oct 4, 2024
@mui-bot
Copy link

mui-bot commented Oct 4, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-43987--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 4c55718

mnajdova
mnajdova approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't matter in this case, because we have only one state call in the handler, there is nothing to batch, but I am ok with merging this 👌

@mnajdova mnajdova added docs Improvements or additions to the documentation component: toggle button This is the name of the generic UI component, not the React module! labels Oct 4, 2024
@mnajdova
Copy link
Member

mnajdova commented Oct 4, 2024 •
edited
Loading

I can't push directly to your master branch, but you need to run the following commands and push the changes in order to fix the CI:

pnpm install
pnpm prettier
pnpm docs:typescript:formatted

@barrownicholas
Copy link
Contributor Author

I can't push directly to your master branch, but you need to run the following commands and push the changes in order to fix the CI

@mnajdova good catch, it looks like that worked. All CI tests are passing now, whenever you have a second to take a look at this.

mnajdova
mnajdova approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for working on this! :)

@mnajdova mnajdova merged commit 5d5e390 into mui:master Oct 8, 2024
23 checks passed
This was referenced Oct 31, 2024
Merged
Merged
@Souviksamanta34 Souviksamanta34 mentioned this pull request Oct 31, 2024
Open
@bansikah22 bansikah22 mentioned this pull request Oct 31, 2024
Merged
This was referenced Oct 31, 2024
Open
Open
This was referenced Nov 1, 2024
Open
Open
@josetutis josetutis mentioned this pull request Nov 2, 2024
Open
@Hoang-Nguyen-Huy Hoang-Nguyen-Huy mentioned this pull request Nov 2, 2024
Merged
@Hoang-Nguyen-Huy Hoang-Nguyen-Huy mentioned this pull request Nov 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
component: toggle button This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] Incorrect React useState Example on Toggle Button
3 participants
@barrownicholas @mui-bot @mnajdova